Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DISTINCT to Jobs realm JobDataset query #1332

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Add DISTINCT to Jobs realm JobDataset query #1332

merged 3 commits into from
Jun 9, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Jun 9, 2020

Description

Adds DISTINCT to the jobs realm JobDataset queries to prevent duplicates due to jobs that span multiple days.

Motivation and Context

https://app.asana.com/0/342819846538629/1179297094155667/f

Tests performed

Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added bug Bugfixes Category:Job Viewer Job Viewer labels Jun 9, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Jun 9, 2020
@jtpalmer jtpalmer requested a review from jpwhite4 June 9, 2020 16:20
@jtpalmer jtpalmer merged commit 6397018 into ubccr:xdmod9.0 Jun 9, 2020
@jtpalmer jtpalmer deleted the job-jobdataset-fix branch June 9, 2020 18:12
@jtpalmer jtpalmer mentioned this pull request Jun 13, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

@jpwhite4 jpwhite4 Awaiting requested review from jpwhite4

Assignees
No one assigned
Labels
bug Bugfixes Category:Job Viewer Job Viewer
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpalmer @plessbd