updates needed for xsede groupbys #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
force-pushed
the
gb-support-alternate-attribute-table
branch
from
ca53939
to
b3df0cd
Compare
plessbd
force-pushed
the
gb-support-alternate-attribute-table
branch
4 times, most recently
from
bd05806
to
73e627d
Compare
plessbd
force-pushed
the
gb-support-alternate-attribute-table
branch
from
73e627d
to
1fdf018
Compare
jpwhite4
reviewed
May 1, 2020
jpwhite4
reviewed
May 1, 2020
plessbd
force-pushed
the
gb-support-alternate-attribute-table
branch
from
1fdf018
to
b9dd3de
Compare
jpwhite4
reviewed
May 1, 2020
jpwhite4
approved these changes
May 4, 2020
jpwhite4
added a commit
to jpwhite4/xdmod
that referenced
this pull request
May 29, 2020
This change fixes an issue seen with the group by Grant Type in the XSEDE realm. and is seen when using a group by configuration that has multiple joins and the dimension table primary key is not stored in the fact tables. See pull ubccr#1288 for more context.
jtpalmer
added
autodoc:ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XSEDE GroupBys need to be able to use a secondary table to link to aggregates (through the account table to the grant table) this update allows that, while getting rid of the need for the attribute_table key as it is provided by the first (and usually only) join table in the attributes value query.