Fix bug in highchart wrapper code. #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code tries to shade the legend background when the data in the chart are restricted by roles. This happens e.g. when you have user role and try to plot some supremm data. Pie charts do not have legends so the series.legendItem property is absent. This change makes sure the legend background colour is only changed if there is a legend to change.
plessbd
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code tries to shade the legend background when the data in the chart
are restricted by roles. This happens e.g. when you have user role and
try to plot some supremm data. Pie charts do not have legends so the
series.legendItem property is absent. This change makes sure the legend
background colour is only changed if there is a legend to change.