Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error message instead of "Loading..." #1280

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

plessbd
Copy link
Contributor

@plessbd plessbd commented Apr 4, 2020

When there is an error in get_menus it can get 'lost' behind a 'Loading...' this will surface the error so that an admin can fix the configuration files.

@plessbd plessbd requested a review from ryanrath April 4, 2020 04:14
html/gui/js/modules/Usage.js Outdated Show resolved Hide resolved
Co-Authored-By: Jeffrey T. Palmer <[email protected]>
@plessbd plessbd merged commit a405d91 into ubccr:xdmod9.0 Apr 6, 2020
@plessbd plessbd deleted the surface-error branch April 6, 2020 14:21
@jtpalmer jtpalmer added this to the 9.0.0 milestone Aug 10, 2020
@jtpalmer jtpalmer changed the title Surface Error instead of sitting on "Loading..." Display error message instead of "Loading..." Aug 10, 2020
@jtpalmer jtpalmer added bug Bugfixes Category:General General labels Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:General General
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants