Fix some bugs in FilterListBuilder #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
force-pushed
the
filterlistbuilder-bugs
branch
2 times, most recently
from
357ac6d
to
2b0bd2b
Compare
plessbd
force-pushed
the
filterlistbuilder-bugs
branch
from
2b0bd2b
to
62c483f
Compare
|
Note that the logging issues were caused by #1240 |
jtpalmer
suggested changes
Mar 12, 2020
jtpalmer
approved these changes
Mar 12, 2020
|
Since the tables are now always being recreated it might be worth considering combining the |
|
I will look at doing that as part of another pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found a few bugs in the filterlistbuilder...