Fix multi-timeseries dataset-show-remainder bug #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have multiple datasets in the metric explorer and tick 'show remainder' then the remainder calculation is incorrect for all but the dataset with the largest series count. This is because the maximum number of series per dataset is used to compute the remainder rather than the number of series for each dataset. Also added a test to confirm the correct behaviour.
|
Kudos, SonarCloud Quality Gate passed!
|
plessbd
approved these changes
Feb 28, 2020
jtpalmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have multiple datasets in the metric explorer and tick 'show
remainder' then the remainder calculation is incorrect for all but the
dataset with the largest series count. This is because the maximum
number of series per dataset is used to compute the remainder rather
than the number of series for each dataset.
Also added a test to confirm the correct behaviour.