Fix show remainder calculation for Jobs by System Username #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a regression test to check that the remainder calculation is performed correctly.
|
Kudos, SonarCloud Quality Gate passed!
|
jtpalmer
approved these changes
Feb 28, 2020
jtpalmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a regression test to check that the remainder calculation is
performed correctly.
Description
The System Username group by in the Jobs realm used an incorrect column name when building the where conditions that are used in the remainder calculation in the metric explorer. This means that the "Avg of N others" calculation was actually the "Avg of all values". This fixes the query and adds a test to confirm the correct value. I've also added a couple of tests for the other types of remainder calculation.