Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding table name to remove ambiguity from group by statement #1228

Merged

Conversation

eiffel777
Copy link
Contributor

@eiffel777 eiffel777 commented Feb 12, 2020

This fixes the following error seen in the metrics-dev logs.

2020-02-12 04:19:05 [warning] SQL warnings on table '`modw_cloud`.`instance`' generated by action xdmod.jobs-cloud-extract-generic.GenericCloudInstanceIngestor
2020-02-12 04:19:05 [warning] Warning 1052 Column 'service_provider' in group statement is ambiguous

Tests performed

Ran in docker and manually tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eiffel777 eiffel777 self-assigned this Feb 12, 2020
@eiffel777 eiffel777 added bug Bugfixes Category:Cloud Cloud Realm labels Feb 12, 2020
@eiffel777 eiffel777 added this to the 9.0.0 milestone Feb 12, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@eiffel777 eiffel777 merged commit ab3b453 into ubccr:xdmod9.0 Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:Cloud Cloud Realm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants