Fix stderr checkbox disablement in Metric Explorer. #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Err Bars" and "Err Labels" columns in the "Data" menu in the metric explorer were incorrectly shown or incorrectly not shown in certian circumstances. a) if a chart was 'geared over' from the Usage Tab then the "Data" menu would always show the "Err Bars" and "Err Labels" checkboxes regardless of whether they should have been shown. b) if data were added to the metric explorer from the "Metric Catalog" then the "Data" menu would never show the checkboxes regardless of whether they should have been shown. If data are added to a chart via the "Data Series Definition" dialog then the checkboxes are correct. This change fixes it so the checkboxes work correctly.
jtpalmer
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Err Bars" and "Err Labels" columns in the "Data" menu in the metric
explorer were incorrectly shown or incorrectly not shown in certian
circumstances.
a) if a chart was 'geared over' from the Usage Tab then the "Data" menu would
always show the "Err Bars" and "Err Labels" checkboxes regardless of whether
they should have been shown.
b) if data were added to the metric explorer from the "Metric Catalog" then
the "Data" menu would never show the checkboxes regardless of whether they
should have been shown.
If data are added to a chart via the "Data Series Definition" dialog then the
checkboxes are correct.
This change fixes it so the checkboxes work correctly.
Old:
New:
Old:
New: