Update organization affiliation change email #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
reviewed
Dec 10, 2019
classes/XDUser.php
Outdated
| @@ -2522,7 +2522,7 @@ public function synchronizeOrganization() | |||
| 'body' => sprintf( | |||
| self::USER_NOTIFICATION_EMAIL, | |||
| $this->getFormalName(), | |||
| \xd_utilities\getConfiguration('mailer', 'sender_email') | |||
| \xd_utilities\getConfiguration('general', 'contact_page_recipient') | |||
There was a problem hiding this comment.
suggest setting the replyAddress to \xd_utilities\getConfiguration('general', 'contact_page_recipient') so that if the user replys to the email it goes to the correct place.
There was a problem hiding this comment.
@jpwhite4 I've added the replyTo. Should the body of the email even contain the address given this change?
There was a problem hiding this comment.
I'd leave the email address in the body too. It doesn't hurt to provide redundant info.
ryanrath
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the text of the organization affiliation change user notification email, the contact email address used in the message, and the reply-to address.
Motivation and Context
I'm not sure what is the best contact email to use in this email, but it's definitely not the "sender" email, which in our case is a "do-not-reply" email address. I think the contact page email makes sense, but there is also an argument for using the technical support email address. We use the same email address for both so it doesn't make any difference to us.
I've also removed a blank line, and replaced "@" with "at" since using "@" is an unnecessary abbreviation.
Tests performed
No tests.
Types of changes
Checklist: