Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module filtering #1170

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Fix module filtering #1170

merged 1 commit into from
Dec 10, 2019

Conversation

jpwhite4
Copy link
Member

@jpwhite4 jpwhite4 commented Nov 27, 2019

The module filtering code had several problems:

  1. the filterByModule() function always included the base module in the result set. This contradicted the function documentation. This meant that the acl-config code was doing N-times the work when N different modules were installed.
  2. configuration objects were being filtered only arrays. This meant that the datawarehouse configuration filtering did not work at all and the groupby and statistics information in the database all had incorrect module attribution.

Changes are as follows:

  • update filterByMetaData to correctly remove objects that should be removed
  • update filterByModule to only return the data for the module rather than return the data for the module and the base module
  • acl-config changes to allow for the fact that a module may not provide any settings.
  • update unit test expected results as appropriate.

@jpwhite4 jpwhite4 added this to the 9.0.0 milestone Nov 27, 2019
@jpwhite4 jpwhite4 added bug Bugfixes Category:ACL Access Control Lists labels Nov 27, 2019
@jpwhite4 jpwhite4 merged commit 88d8a02 into ubccr:xdmod9.0 Dec 10, 2019
@jpwhite4 jpwhite4 deleted the module branch December 10, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:ACL Access Control Lists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants