Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module filtering code had several problems:
filterByModule()
function always included the base module in the result set. This contradicted the function documentation. This meant that theacl-config
code was doing N-times the work when N different modules were installed.datawarehouse
configuration filtering did not work at all and the groupby and statistics information in the database all had incorrect module attribution.Changes are as follows:
filterByMetaData
to correctly remove objects that should be removedfilterByModule
to only return the data for the module rather than return the data for the module and the base module