Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

ResultsView not working for 310 d2 #40

Open
rtholmes opened this issue Feb 19, 2018 · 0 comments
Open

ResultsView not working for 310 d2 #40

rtholmes opened this issue Feb 19, 2018 · 0 comments
Assignees

Comments

@rtholmes
Copy link
Contributor

The backend route for the results view is working for d0 and d1 but not for d2 (and won't work for d3 either). This is because .projectUrl is '' for every student in ResultPayloadInternal.students. I think this is because d2 is running against a d1 repo. We need to deal with this more flexibly.

This would be easy to fix if we could count on every student invoking the bot against some repo for d2 and just using the projectUrl from the execution for the projectUrl param for the student, but since we can't (e.g., because they didn't do it or their students made all the requests), we end up being really stuck here.

Ultimately, the ResultView in the UI is getting an incomplete response from the backend and cannot render it properly. The change that is needed is really straightforward, the projectUrl field cannot be empty for student and has to be set to its correct value. After fighting this for the morning though, it isn't clear the fix itself will be easy (without doing something that would break the view for 210 or past 310 deliverables too).

rtholmes added a commit that referenced this issue Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants