You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
The backend route for the results view is working for d0 and d1 but not for d2 (and won't work for d3 either). This is because .projectUrl is '' for every student in ResultPayloadInternal.students. I think this is because d2 is running against a d1 repo. We need to deal with this more flexibly.
This would be easy to fix if we could count on every student invoking the bot against some repo for d2 and just using the projectUrl from the execution for the projectUrl param for the student, but since we can't (e.g., because they didn't do it or their students made all the requests), we end up being really stuck here.
Ultimately, the ResultView in the UI is getting an incomplete response from the backend and cannot render it properly. The change that is needed is really straightforward, the projectUrl field cannot be empty for student and has to be set to its correct value. After fighting this for the morning though, it isn't clear the fix itself will be easy (without doing something that would break the view for 210 or past 310 deliverables too).
The text was updated successfully, but these errors were encountered:
The backend route for the results view is working for d0 and d1 but not for d2 (and won't work for d3 either). This is because
.projectUrl
is''
for every student inResultPayloadInternal.students
. I think this is becaused2
is running against ad1
repo. We need to deal with this more flexibly.This would be easy to fix if we could count on every student invoking the bot against some repo for
d2
and just using theprojectUrl
from the execution for theprojectUrl
param for the student, but since we can't (e.g., because they didn't do it or their students made all the requests), we end up being really stuck here.Ultimately, the
ResultView
in the UI is getting an incomplete response from the backend and cannot render it properly. The change that is needed is really straightforward, theprojectUrl
field cannot be empty forstudent
and has to be set to its correct value. After fighting this for the morning though, it isn't clear the fix itself will be easy (without doing something that would break the view for 210 or past 310 deliverables too).The text was updated successfully, but these errors were encountered: