-
Notifications
You must be signed in to change notification settings - Fork 31
style: wrap recent changelog at 80 chars per line #629
style: wrap recent changelog at 80 chars per line #629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triggering some linting errors. +1 when CI checks successful.
If only there were some way this linting could automatically run for me when I locally commit... :) |
cd4c48f
to
7e5e0f0
Compare
(That next failure was because my commit message on the linting fix ended with a period and so itself failed commit message linting. If only there were some way my commit messages could be linted locally when I commit them... :) ). So, the helpful version of this joke is this: that there are tradeoffs between local and CI linting, and I'm navigating them, badly. One root problem here is that this linting isn't working for me locally -- I imagine |
Ahh, the old git commit messages aren't sentences gotcha. Have you tried npm install before running npm run lint-md? I'll pull down the code and see if it works for me. |
So, yes, I had tried |
acc36ab
to
e4ecac2
Compare
(And apparently the next failure was because my commit message led with |
Hey @apetro 👋 Also, it may be valuable if you share your experiences and thoughts on how to improve the commit message experience at https://github.com/marionebl/commitlint/issues/94. |
I'd check which version of npm is being run versions 5.1.0+ are much more consistent with installing modules than previous versions. Its also worth noting that running |
That's the dream. 🙂 |
Wrap recent changelog lines at 80 characters per line.
Contributor License Agreement adherence: