Skip to content
This repository was archived by the owner on Sep 19, 2020. It is now read-only.

behind-the-scene broken at gmail #62

Closed
6 of 7 tasks
uBlock-user opened this issue Sep 24, 2018 · 49 comments
Closed
6 of 7 tasks

behind-the-scene broken at gmail #62

uBlock-user opened this issue Sep 24, 2018 · 49 comments
Labels
bug Something isn't working Chromium specific to Chromium/Chrome fixed issue has been addressed

Comments

@uBlock-user
Copy link
Contributor

uBlock-user commented Sep 24, 2018

Prerequisites

  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • This is not a support issue or a question
    • Support issues and questions are handled at /r/uMatrix
  • I tried to reproduce the issue when...
    • uMatrix is the only extension
    • uMatrix with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uMatrix
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

On gmail, behind-the-scene requests are blocked unconditionally and th refresh button on the for behind-the-scene panel doesn't work. BTS Refresh button broke with v1.3.0 and BTS network requests are being blocked unconditionally since 1.3.8.

A specific URL where the issue occurs

https://mail.google.com/mail/u/0/?tab=wm#inbox

Steps to Reproduce

  1. Disable ALL extensions and install uMatrix from https://github.com/gorhill/uMatrix/releases/tag/1.3.15b2

  2. Once installed, visit gmail and login with your credentials

  3. Open the logger and refresh the page to populate, once loaded, page will appear broken, because behind-the-scene network requests are being blocked unconditionally. even though it's default installation where matrix is set to off for behind-the-scene.

  1. Click on a behind-the-scene network request to open up behind-the-scene popup panel and now click on the refresh button, the tab doesn't refresh.

Supporting evidence

Errors collected via Chromium on v1.3.0 regarding the refresh button issue -

Broken refresh button at BTS panel and BTS network requests being blocked unconditionally -

https://i.gyazo.com/014e222d6d50f97d57c3d66869f0b0c8.mp4

Your environment

  • uMatrix version: 1.13.15.2
  • Browser Name and version: Chromium 71
  • Operating System and version: Win 10 x64
@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

Because of this, gmail remains broken for me as in I can't use funcionality such as Add to Drive and download attachments/images don't load etc.. until I disable this extension from Extensions page. Seems to be happening with Firefox. Let me know if you're unable to reproduce.

@uBlock-user uBlock-user added the bug Something isn't working label Sep 24, 2018
@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

th refresh button on the for behind-the-scene panel doesn't work

Of course, "behind-the-scene" means there is no specific tab associated with the request, hence there no tab for uMatrix to refresh. This is not new behavior, this has always been the case.

Open the logger and refresh the page to populate, once loaded, page will appear broken

I only have a "dont-care" Gmail account for testing purpose, and I logged in into it without issue and I could not spot anything broken. I don't have emails with attachment in it or even a Google Drive account, so it would help to tell me what exactly is broken with screenshots, etc. The simpler the better, otherwise this will be a cant-reproduce issue.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

Of course, "behind-the-scene" means there is no specific tab associated with the request, hence there no tab for uMatrix to refresh. This is not new behavior, this has always been the case.

So why does v1.3.0/4/6 spew errors like this -

what exactly is broken with screenshots

BTS requests are being blocked unconditionally on my end, because of this, gmail remains broken for me as in I can't use funcionality such as Add to Drive and download attachments/images don't load etc..

I only have a "dont-care" Gmail account for testing purpose, and I logged in into it without issue and I could not spot anything broken. I don't have emails with attachment in it or even a Google Drive account

I feared this would happen, I posted all the information I could gather here, don't know what else I could give you.

@uBlock-user
Copy link
Contributor Author

I could e-mail you a dummy pdf on your gmail account if you want.

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

So why does v1.3.0/4/6 spew errors like this

I don't get that with latest uMatrix. I can't say it didn't happen with 1.3.0, but that is an old version, you shouldn't be reporting issue with older versions unless they also occur in current stable.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

The reason I'm reporting from that version is because the latest dev build doesn't throw such StackTrace errors even though when refresh button is clicked from BTS panel and it doesn't anything, but only v 1.3.0/4/6 do.

@uBlock-user
Copy link
Contributor Author

console errors if they help any -

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

the latest dev build doesn't throw such StackTrace

Because the issue is no longer present? That was my point: why report issues from past versions which no longer exist in the latest stable release. This was probably fixed in 1.3.8.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

OK, but what about those BTS requests being blocked unconditionally ?

FYI, you may have to enable Collect Errors from chrome://extensions/?id=eckgcipdkhcfghnmincccnhpdmnbefki if you're not seeing any in Extension page.

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

This is the ruleset I have when trying to reproduce:

https-strict: behind-the-scene false
matrix-off: about-scheme true
matrix-off: chrome-extension-scheme true
matrix-off: chrome-scheme true
matrix-off: moz-extension-scheme true
matrix-off: opera-scheme true
matrix-off: vivaldi-scheme true
matrix-off: wyciwyg-scheme true
noscript-spoof: * true
referrer-spoof: * true
referrer-spoof: behind-the-scene false
* * * block
* * css allow
* * frame block
* * image allow
* 1st-party * allow
* 1st-party frame allow
google.com gstatic.com * allow

What about yours?

@uBlock-user
Copy link
Contributor Author

same as yours on default rule set

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

Don't you need to set google.com gstatic.com * allow? I needed this -- to un-break logging in.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

Yes I did add it as temp rule and it works on default installation, so now I go back to my regular config and the images and thumbnails do load but add to Drive is still stuck, very weird case, spend 4 hours on this already and still can't figure whats going on.

Thing is my regular config rules worked perfectly until today, today it stopped.

@uBlock-user
Copy link
Contributor Author

Done. Sent my regular ruleset alongwith.

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

I could open your attachments, and also download locally, but the later required me to add google.com googleusercontent.com frame allow from the popup panel.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

With mail.google.com gstatic.com script allow the images and thumbnails remain broken,

With mail.google.com gstatic.com * allow , the images and thumbnails load fine.

Very weird, I have never needed these two rules for images and thumbnails to load until today.

@uBlock-user
Copy link
Contributor Author

Another thing mail.google.com gstatic.com * allow doesn't fix the Save To Drive functionality which is still broken.

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

I could "Save to Drive" fine. However the "Save to Drive" popup was blank, I fixed by adding the following rules:

mail.google.com content.googleapis.com * allow
mail.google.com googleusercontent.com * allow

The first one might not be needed, it's the one I tried first.

Edit: I didn't need to reload by the way, and I confirm only the 2nd seem necessary.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

I don't get any popups, I click on the button and it goes into an infinite loop of Saving to Drive...it's fine I will figure that one out.

Since I don't wanna whitelist the entire gstatic.com on mail.google.com, so I narrowed it down to

mail.google.com ssl.gstatic.com xhr allow
mail.google.com www.gstatic.com xhr allow

These two rules bring back the broken images and thumbnails, but weird thing is there's no XHR being made from those rules or atleast a number doesn't appear on those cells

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

As per your per-site switch count, you are blocking workers -- I didn't see this in your ruleset screenshot above. Gmail does use workers.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

Okay so XHRs re coming from those ssl.gstatic.com and www.gstatic.com but those are behind-the-scene requests, and since BTS is already whitelisted, so I shouldn't need to add

mail.google.com ssl.gstatic.com xhr allow
mail.google.com www.gstatic.com xhr allow

Right ?

@uBlock-user
Copy link
Contributor Author

No workers appear blocked on my end

@uBlock-user
Copy link
Contributor Author

@gorhill If I don't add

mail.google.com ssl.gstatic.com xhr allow
mail.google.com www.gstatic.com xhr allow

BTS XHRs get blocked, why is that, why does BTS is getting affected by those rules ?

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

No workers appear blocked on my end

Well you opened this issue a few months ago: #22.

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

BTS XHRs get blocked, why is that, why does BTS is getting affected by those rules ?

I can't remember where but we talked about how "behind-the-scene" changed in uMatrix: not all entries marked as "behind-the-scene" are real actual behind-the-scene, because now uMatrix makes use of initiator if present to filter request, and when the initiator is present, the logger still report the request as behind the scene -- there is still no specific tab involved, but there is a specific origin, as opposed to real behind-the-scene where there is no tab and no origin. I just miss the time to overhaul the logger to now account for this. This is also true for uBO.

@uBlock-user
Copy link
Contributor Author

I disabled all th 4 switches and still no change, so it's not the same, BTS XHRs are getting blocked regardless of workers switch enabled or not.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

I can't remember where but we talked about how "behind-the-scene" changed in uMatrix: not all entries marked as "behind-the-scene" are real actual behind-the-scene, because now uMatrix makes use of initiator if present to filter request, and when the initiator is present, the logger still report the request as behind the scene -- there is still no specific tab involved, but there is a specific origin, as opposed to real behind-the-scene where there is no tab and no origin.

I think you nailed it there. That only makes logical sense.

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

You could use uBO's logger just to find out the context in which these XHRs are made (uMatrix does not have this information in the logger yet). For the target XHRs, click the cell to create filters in uBO's logger, the context (aka initiator) will be shown.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Sep 24, 2018

Context is mail.google.com, so it's not BTS as it's shown by both the extensions.

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

With uBO it's merely cosmetic -- one can create proper rules/filters -- just need to have a different icon to convey that a request is not associated with any specific tab but yet its origin is known (with real behind-the-scene the origin aka context is unknown).

@uBlock-user
Copy link
Contributor Author

I meant do you intend to fix uBO's logger regarding this issue ?

@gorhill
Copy link
Member

gorhill commented Sep 24, 2018

gorhill added a commit to gorhill/uMatrix that referenced this issue Sep 29, 2018
@gorhill
Copy link
Member

gorhill commented Sep 29, 2018

A column has been added to the logger: the scope in which network requests are made. Thus, the behind-the-scene scope is now shown just like any other scope: behind-the-scene. The block/allow column is clickable and must be use to set rules specific strictly to the entry.

@gorhill gorhill closed this as completed Sep 29, 2018
@uBlock-user uBlock-user added the fixed issue has been addressed label Oct 3, 2018
@uBlock-user
Copy link
Contributor Author

uBlock-user commented Oct 3, 2018

Still doesn't show number of requests on XHR matrix cell, so the user still won't know which cell to whitelist to stop breakage, Also why are those requests still shown as BTS ?

Fixed in 1.3.15.8

@gorhill
Copy link
Member

gorhill commented Oct 3, 2018

Can you provide a screenshot of what you are seeing? If a request is shown as behind-the-scene, than it is really behind-the-scene.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Oct 3, 2018

Still doesn't show number of requests on XHR matrix cell, so the user still won't know which cell to whitelist to stop breakage,

This

The situation at gmail is still the same, those XHR whitelisted cells from ssl.gstatic.com and www.gstatic.com still don't show number of requests inside them.

If the requests were really BTS, then how come whitelisting those two XHR cells fixes the breakage ?

Fixed in 1.3.15.8

@gorhill
Copy link
Member

gorhill commented Oct 3, 2018

The fix was in the logger -- you should be able to see in the logger these requests -- they will no longer be reported as "behind-the-scene" unless they really are. uMatrix is not reporting them in the popup panel of that tab probably because there is no tab information provided for these specific requests. In such case, the logger is where ultimately those problems are resolved, hence the new UI in the logger.

This is what can happen:

  • tab specified, scope known (all reported in the matrix): use the popup panel or logger
  • tab not specified, scope known (probably your case): use the logger
  • tab not specified, scope unknown (these are literal behind-the-scene): use the popup panel of behind-the-scene or logger

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Oct 3, 2018

uMatrix is not reporting them in the popup panel of that tab probably because there is no tab information provided for these specific requests.

Can anything be done about this ?

This is how it looks like via the logger -

@gorhill
Copy link
Member

gorhill commented Oct 3, 2018

Can anything be done about this ?

No, as said, the request is made outside of any tab context, uMatrix has no idea from which tab the request is originating. As shown in your pic, this is solved via the logger, you can set rules for that one request. That new UI in the logger also solves gorhill/uMatrix#951.

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Oct 10, 2018

Thanks to this new UI, asset updates on Firefox are now initiated by moz-extension-scheme and on Chromium it's chrome-extension-scheme, those who disable uMatrix on both these schemes won't be affected, but thought I would post for those like me who go with whitelist and blocking the rest, due to this change, the BTS popup panel is misleading and is required to be removed FYI.

@gorhill gorhill reopened this Oct 16, 2018
@gorhill
Copy link
Member

gorhill commented Oct 16, 2018

I will need to provide access to the per-scope switches from the new per-entry rule editor UI.

@uBlock-user uBlock-user added the something to address something to address label Oct 16, 2018
@uBlock-user
Copy link
Contributor Author

images are not loading again, are being seen by BTS in the logger ? Can you confirm if it's really from BTS ?

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Dec 25, 2018

Update -

On Chromium -

On Firefox -

Notice the XHR cell count for gstatic.com doesn't appear on Chromium's dev build.

@gwarser
Copy link

gwarser commented Dec 25, 2018

In Chromium service worker loads all gstatic XHRs using tab-less mail.google.com context.

In Firefox they are not tab-less.


Maybe some indicator should be added to the popup (for example to scope selector) when tab-less request occur in current context?

@uBlock-user
Copy link
Contributor Author

uBlock-user commented Dec 25, 2018

Tabless requests number count should also be shown in the main popup UI to combat this. The cell count number not appearing is really troubling.

@uBlock-user uBlock-user removed the fixed issue has been addressed label Dec 25, 2018
@uBlock-user uBlock-user added fixed issue has been addressed and removed something to address something to address labels Mar 3, 2019
@uBlock-user uBlock-user added the Chromium specific to Chromium/Chrome label Mar 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Chromium specific to Chromium/Chrome fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants