Skip to content
This repository was archived by the owner on Sep 19, 2020. It is now read-only.

Placeholder iframe not shown on particular site using Firefox #28

Closed
7 tasks done
xofe opened this issue Jul 5, 2018 · 4 comments
Closed
7 tasks done

Placeholder iframe not shown on particular site using Firefox #28

xofe opened this issue Jul 5, 2018 · 4 comments
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed

Comments

@xofe
Copy link

xofe commented Jul 5, 2018

Prerequisites

  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • This is not a support issue or a question
    • Support issues and questions are handled at /r/uMatrix
  • I tried to reproduce the issue when...
    • uMatrix is the only extension
    • uMatrix with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uMatrix
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

A specific URL where the issue occurs

http://lyrics.wikia.com/wiki/Florence_%2B_The_Machine:Hunger

Steps to Reproduce

  1. Open Firefox 60 or later (using a clean profile) and install uMatrix 1.1.20 or later.
  2. Add the rule wikia.com nocookie.net * allow to the 'My rules' section in the dashboard. (Without this rule, the site will appear broken)
  3. Visit the URL above.
  4. Notice that the usual iframe placeholder document for the YouTube video embed at the top right of the grey lyrics box (an iframe from www.youtube-nocookie.com, which is blocked) is not shown.

Supporting evidence

This only affects Firefox 60 or later when used with uMatrix 1.1.20 or later. The issue isn't present when using Firefox 59 or older with the current version of uMatrix, or when using uMatrix 1.1.18 or older with the current version of Firefox. Because of this, I'm not certain whether this is a Firefox or uMatrix issue.

For Firefox, moz-regression gives a regression range that points to Bug 1193394.

For uMatrix, git bisect says gorhill/uMatrix@73c8da0 is the culprit.

Screenshot of last good revision (gorhill/uMatrix@8615f3b) on Firefox 60.0.2 :
Screenshot whit placeholder shown
Screenshot of first bad revision (gorhill/uMatrix@73c8da0) on Firefox 60.0.2 :
Screenshot whit placeholder missing

Your environment

  • uMatrix version: 1.3.10
  • Browser Name and version: Firefox 60.0.2
@uBlock-user
Copy link
Contributor

I can reproduce on Nightly.

@uBlock-user uBlock-user added bug Something isn't working Firefox specific to Firefox labels Jul 5, 2018
@uBlock-user
Copy link
Contributor

Make sure you have disabled Collapse placeholder of blocked elements and Collapse placeholder of blacklisted elements from the Settings menu.

@gorhill
Copy link
Member

gorhill commented Jul 5, 2018

I can reproduce. Appears to be a timing issue, when I stepped into the javascript code, the placeholder appeared properly.

@uBlock-user uBlock-user added the fixed issue has been addressed label Jul 5, 2018
@xofe
Copy link
Author

xofe commented Jul 5, 2018

Confirmed fixed. Thanks!

Noxgrim pushed a commit to Noxgrim/uMatrix that referenced this issue Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants