Viptube.com

[ghost]

Describe the issue

This filter does not block all domains of this advertiser anymore. Maybe a filter like this one should be added.
||data.*.com^$document

One or more specific URLs where the issue occurs

NSFW:
http://www.viptube.com/
Click anywhere on the site to be redirected to the ad domain (data.potpourrichordataoscilloscope.com).

https://forums.lanik.us/viewtopic.php?f=62&t=29559
On the provided example site the Yavli ads on the right redirect through data.inertanceretinallaurel.com.

Your settings

• Browser/version: Chrome 49
• uBlock Origin version: uBlock Origin Version 1.6.6

[gorhill]

I will let you make the changes. Once the filters are updated -- always be sure the checksums are updated as well before the committing to the repo -- there is the shell script tool/update-ublock0.sh for this. See https://github.com/uBlockOrigin/uAssets/blob/master/CONTRIBUTING.md for details on how to add filters.

All users of 1.6.8 and beyond are now pulling assets from this repo, so the checksums have to match all the state of the repo, or else their lists will be marked as in need of update all the time.

In doubt, just ask.

[ghost]

What about the filters in gorhill/uBlock? Will you change them when I make a commit here?

[gorhill]

The filters in gorhill/uBlock are no longer updated now that v1.6.8 is out for all supported browsers. I will eventually remove most of the content from the gorhill/uBlock/assets branch once I am confident everybody moved to 1.6.8 (there is no good reason to linger behind). The package-building script already pulls assets from uBlockOrigin/uAssets, it ignores the content of gorhill/uBlock/assets branch.

[mjdaly]

Hi @gorhill, our users (https://data.docurec.com) are complaining about this filter.

data is a nice, short & obvious sub-domain to use for web services or apps. I would expect that lots of services are blocked by such an open rule.

Can this be refined or reverted?

[gorhill]

@mjdaly Sorry for the overly broad filter, I reduced its scope to only the site documented in the issue.

[mjdaly]

Many thanks.

[ghost]

@gorhill Could you please add this site too?
vivatube.com
I'm not really able to do it until I find a solution for the issue with Desktop.

[ghost]

This one uses the same popunders when opening a video and clicking the play button:
nuvid.com

[ghost]

Needs inclusion: tvil.me

[ghost]

Thanks. This one too: hqprn.com [nsfw]

[ghost]

Another one: pornsharing.com [NSFW]
Thanks for gorhill/uBlock#1735 by the way! Seems to be quite powerful on a lot of sites.

[ghost]

Thanks. Also this: befuck.com [NSFW]

[ghost]

Appreciate it. [NSFW] wetplace.com

[ghost]

[NSFW] http://coreimg.net/lsisl48fzpn8
When clicking "Continue to image..." and then clicking somewhere on the page with the image the popunder is spawned. Though the legitimate popup is being closed by data:text/html;base64$popup in EasyList. Additionally popups are spawned before clicking continue using data:text/html without the base64 part.

[gorhill]

I don't see any popunders matching ||data.*.com^ on that page -- I only got popups:

[ghost]

It appears when clicking on the page that you get after you "continued".

EasyList just changed the filter to combat the popups. easylist/easylist@7df67ad
The legit tab is still blocked like you can see in the screenshot (it's the base64 one).

[gorhill]

Ok I see. So the filter data:text/html$popup is causing an issue here, as it prevent the popunder code path from being taken. Is it the conclusion you are also coming to?

[ghost]

Yes, that's it. Should EasyList fix this?

[ghost]

Thanks, that seems to solve it completely.
Here's another case where there's this type of popunder and a data:text/html;base64 popup being the real site: [NSFW] lomapornotube.com

[gorhill]

There is not much I can do for this, blocking popups through such a broad filter as data:text/html has the potential to create a lot of false positives, and this is being exploited. This data:text/html filter now gets in the way of uBO's popunder blocker, while it accomplishes little to nothing for ABP because of its shortcomings -- but ABP has priority for EasyList maintainers.

[ghost]

Another one: [NSFW] pornoid.com