-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ArduinoJson (Using ARDUINOJSON_VERSION_MAJOR) #993
Conversation
hotfix: rename internal HTTP_HEAD to HTTP_HEADER
separate charset UTF-8 and viewport meta
Fixed: Waiting for connection result with time out issue
I think this works for library managers..
trying a different format
Perfect, but I think is better automate it replacing |
Ok good suggestion. Thank you I didn't know there is a way to do that. Will update it soon |
I should have rebased this.. Should be ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the sketch, there is not "}" in void setup!
It is correct?
I am having problems with ondemand config portal WithFSParameters using a push button.
Compiles for me |
For me too, but this is strange.... |
This is relates to the ArduinoJson 5 / 6 changes.
I took what @bigjohnson did in a502456 and just added a #define UseJsonV6 option that can be commented out if you want to use ArduinoJsonV5.
Tested on ArduinoJson V 5.13 and ArduinoJson V 6.13 (Latest as at 14/01/2020)
This also links to #654 and #812