Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal: being able to iterate on WifiManagerParameters #717

Closed
fllaca opened this issue Sep 2, 2018 · 2 comments
Closed

Feature proposal: being able to iterate on WifiManagerParameters #717

fllaca opened this issue Sep 2, 2018 · 2 comments
Labels
Documentation Flagged for docs enhancement Feature Request
Milestone

Comments

@fllaca
Copy link
Contributor

fllaca commented Sep 2, 2018

I think iterating on WifiManagerParameters could be interesting, in order to make easier the creation of reusable configuration forms, so you could do something like:

JsonObject& json = ...
....
for (int i=0; i<wifimanager.getParametersCount(); i++){
    WiFiManagerParameter parameter = wifimanager.getParameters()[i];
    json[parameter.getId()] = parameter.getValue();
}

// then save the jsonfile into a file
persistJsontoFS(json);

WDYT?

@tablatronix
Copy link
Collaborator

Hmm makes sense

@tablatronix tablatronix added the enhancement Feature Request label Sep 2, 2018
@tablatronix tablatronix added this to the dev milestone Sep 2, 2018
@JeremyProffitt
Copy link

JeremyProffitt commented Sep 9, 2018

I worry about json parsing and device memory, was looking at one file per perameter model myself. Name the file o/paramname

@tablatronix tablatronix added the Documentation Flagged for docs label Sep 12, 2018
tablatronix added a commit that referenced this issue Oct 3, 2018
Implements #717:  Added getParameters and getParametersCount methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flagged for docs enhancement Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants