Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derives #42

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Add derives #42

merged 4 commits into from
Sep 30, 2024

Conversation

LaurenzV
Copy link
Contributor

No description provided.

@LaurenzV LaurenzV changed the title Add derives for Chunk Add derives Sep 28, 2024
@laurmaedje
Copy link
Member

I think Clone makes sense, but does Eq and PartialEq really make sense for chunks?

As for Debug, we could have something like Chunk(3) when there are three objects in it.

@laurmaedje
Copy link
Member

Or just Chunk(..) like for the Pdf struct.

@LaurenzV
Copy link
Contributor Author

I think Clone makes sense, but does Eq and PartialEq really make sense for chunks?

Damn, I already forgot why I needed it... Just tried it without it and still seems to compile fine for me. 😂 So I guess I'll remove it.

As for Debug, we could have something like Chunk(3) when there are three objects in it.

Isn't Debug already implemented?

@laurmaedje
Copy link
Member

Isn't Debug already implemented?

Nevermind then, I only read the diff.

@laurmaedje laurmaedje merged commit bc4d1e7 into typst:main Sep 30, 2024
2 checks passed
@LaurenzV LaurenzV deleted the chunk-derives branch September 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LaurenzV @laurmaedje