-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
touying-flow:1.0.0 and touying-ustc:0.1.0 #1308
Conversation
Hello, I think your package need to be reworked a little bit. From what I understand, they both include a copy of an old version of touying, which I believe is not the correct way to define themes. You can have a look at what [ |
At first, I felt that the styles of components in Touying did not align with my theme, so I referred to Touying's source code and made some modifications. For convenience, I copied some of Touying's original components, but certain components have been implemented differently from Touying. If this structure is not considered best practice, I will replace them in future updates. By the way, the USTC project does not include packages from Touying. |
@elegaanz I have copied more component implementations than I currently use because I hope to gradually adapt them to my theme in the future while reserving appropriate interfaces in advance. To be honest, these components are not large in size, but they are definitely not redundant parts of the Touying package. |
First of all, thank you for your contribution! However, I don't think you should fork touying now, because it will cause you to not be able to keep up with touying's updates in the future. Touying doesn't make assumptions about how you should write your layout functions, and it ensures the decoupling of various interfaces. You can just copy a small part of it and update it with |
@OrangeX4 thanks for your reply, I will refactor it later. |
I am submitting
Description: Explain what the package does and why it's useful.
This package is a template file created based on the Touying project, with simplicity and practicality as its primary features. It integrates a variety of functions, making it convenient for users to learn and use Typst to create presentations. It is particularly well-suited for academic exchanges in settings such as universities.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE