Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded nested calls #82

Closed

Conversation

therebelrobot
Copy link

Refer: #72 (comment)

@isaacrg > Added as a PR because of #72 (comment)

I am currently sourcing https://github.com/therebelrobot/json-server-nested in my work project, it has everything here except the most recent upstream merge for status code changes.

@ir-g
Copy link

ir-g commented May 11, 2015

This looks awesome.

@typicode, what are your thoughts?

@typicode
Copy link
Owner

Hmm, honestly it's a hard choice and I'm not sure about it.
Also the PR is impressive, it's really cool work.

@isaacrg if you need it, support can easily be added using the project as a module and middlewares.

I've stumbled on projects like express-rewrite:

// Would rewrite /categories/1/posts/1/comments to /posts/1/comments
server.get('/:a/:b/:parent/:parentId/:resource', rewriter.rewrite('/$3/$4/$5')

There's also express-redirect that seems to be an easy solution too.

@ir-g
Copy link

ir-g commented May 12, 2015

@typicode Awesome - thanks for the find. I entirely understand if you don't want to PR this stuff, I get that you may well want to keep the library simple.

@therebelrobot
Copy link
Author

@typicode I echo what @isaacrg said, if you want to keep the lib simple, that's cool. If you do decide to do that, let me know so I can get a separate fork published on npm for the more advanced features.

@typicode
Copy link
Owner

Well let's keep it simple then :) Closing it.

@typicode typicode closed this May 12, 2015
@therebelrobot
Copy link
Author

@kuitos
Copy link

kuitos commented Jul 31, 2015

@therebelrobot awesome, that what I want !! I will try it now

@ir-g
Copy link

ir-g commented Aug 1, 2015

@therebelrobot Awesome work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants