Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: husky.config.js not .huskyrc.config.js #669

Merged
merged 2 commits into from
Feb 12, 2020
Merged

fix: husky.config.js not .huskyrc.config.js #669

merged 2 commits into from
Feb 12, 2020

Conversation

christophehurpeau
Copy link
Contributor

in readme it says:

Starting with 1.0.0, husky can be configured using .huskyrc, .huskyrc.json, .huskyrc.js or husky.config.js file.

@christophehurpeau
fix: husky.config.js not .huskyrc.config.js
e7acc2f 
in [readme](https://github.com/typicode/husky/blob/master/README.md#upgrading-from-014) it says:

> Starting with 1.0.0, husky can be configured using .huskyrc, .huskyrc.json, .huskyrc.js or husky.config.js file.
@christophehurpeau
Copy link
Contributor Author

christophehurpeau commented Feb 12, 2020 •
edited
Loading

bug introduced with 015f3aa#diff-9fde8338c5cc7fec9e2341da618aa311 and 7791433#diff-9fde8338c5cc7fec9e2341da618aa311 in v4.2.2

@typicode
Copy link
Owner

Thanks!

@typicode typicode merged commit d9d8de3 into typicode:master Feb 12, 2020
@christophehurpeau christophehurpeau deleted the patch-2 branch February 13, 2020 09:43
vsn4ik
vsn4ik reviewed Feb 13, 2020
View reviewed changes
sh/husky.sh
@@ -58,7 +58,7 @@ debug "Current working directory is $(pwd)"
# Don't skip if .huskyrc.js or .huskyrc.config.js are used as the heuristic could
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.huskyrc.config.js -> husky.config.js

vsn4ik
vsn4ik reviewed Feb 13, 2020
View reviewed changes
src/installer/__tests__/__snapshots__/scripts.ts.snap
@@ -87,7 +87,7 @@ debug \\"Current working directory is $(pwd)\\"
# Don't skip if .huskyrc.js or .huskyrc.config.js are used as the heuristic could
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.huskyrc.config.js -> husky.config.js

@snyk-bot snyk-bot mentioned this pull request Mar 26, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsn4ik vsn4ik vsn4ik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophehurpeau @typicode @vsn4ik