Win 10 Github Desktop pre-commit hook

[JosefBredereck]

Hello, I have a problem with my pre-commit hook or husky in general when using Github Desktop.
On the first look, it seems to be #1038, but the problem is. It works perfectly fine in VS code.

My environment:
Terminal or GUI client: GitHub Desktop v2.9.4 (x64)
System OS: Windows 10
Node Version: v15.14.0
npm Version: 7.7.6

I followed the following guide
https://typicode.github.io/husky/#/?id=migrate-from-v4-to-v7

After that, I have now "husky": "^7.0.4" in place and get the following error message:

/usr/bin/env: ‘bash’: No such file or directory
husky - pre-commit hook exited with code 127 (error)

Do I have to configure something in the pre-commit file?

# file .husky/pre-commit
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm run lint-staged-hook

[typicode]

Hmm that's weird, nowhere husky is calling bash in husky.sh

[JosefBredereck]

It seems that I'm not the only one. Someone else also opened an issue for the desktop app desktop/desktop #13307 & desktop/desktop #12562

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[KInGATiLLa]

Same here 😞. I'm using from Github desktop. Vscode is fine. But i like github desktop

My environment

OS: Windows 11 latest
Node: 16.3.2
Npm: 8.3.0
Github desktop: 2.9.6 (x64)

[VincentVerweij]

It is not Github Desktop I am using here but Visual Studio 2022 which gives me the exact same error.

While Googling, I did come across issue #1038 and there are some suggestions in there.

Did try to change my .husky/commit-msg from

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx --no -- commitlint --edit 

to

#!/bin/sh
# exit 1 will prevent commit to happen, so you can more easily debug things
echo "it's working" && exit 1 

And Visual Studio 2022 did give me the message it's working with an error symbol (which is normal).

Next I made sure that in my system PATH environment variable I do have C:\Program Files\Git\usr\bin\cygpath.exe included. I do see it when printing out $env:PATH in PowerShell.

Any other suggestions?

[typicode]

Hmm I'm not using Windows enough to help here. However I have GitHub Desktop 2.9.8 working. I also have Git installed with Git Bash on my machine.

I don't see what could be done on husky's side in terms of code.

[VincentVerweij]

I guess it is just Visual Studio which is acting weird here. Currently my workaround is to use Visual Studio Code to commit code which works just fine.
So perhaps it is wrong to post this Visual Studio issue in here, as Husky seems to be working ok.

Still if anyone else knows what is going on here, or has a suggestion of fixing or logging this elsewhere, give a shout.

[typicode]

Closing to clean up issues list, but if anyone has fix ideas feel free to add to this thread.

[johannesschobel]

This issue is still a thing and i can confirm this issue as described the latter.
@JosefBredereck , have you found a solution for this?

[JosefBredereck]

Not for the issue, only a work around. If you go back to node 14 the issue should not appear.

[johannesschobel]

hmmmmmmmmmmmmmmmm~ i will try tomorrow (hopefully) and report back!
However, this is a serious issue / roadblock for the development with windows and husky 😟

[johannesschobel]

maybe @typicode has some more information about this issue in the meantime?! Would it help, if we provide a minimal reproduction repository?

[typicode]

@johannesschobel no more info, sorry :/

[Fariarx]

[johannesschobel]

@chall2chall4 is the code repository located within a wsl2 distro?

@typicode : would you be willing to help and track down the issue in order to solve this problem?

[marie-hughes]

Not for the issue, only a work around. If you go back to node 14 the issue should not appear.

I am using node 14 and I get the issue so I don't think that's a universal solution
Update: was able to get it working with node 14.18.0

[LukeGarrigan]

I get this running in Github Desktop:

It works fine from my current IDE (intellij)

[Fariarx]

@Fariarx is the code repository located within a wsl2 distro?

No, this is just a deployed repository on my windows 11. Specifically taken from here: https://github.com/electron-react-boilerplate/electron-react-boilerplate
I solved it by changing github desktop to another client. (fork) And there were no more problems with it.

[Yiding-Aya]

Add git bin to Path fixed my issue

[DoctorDerek]

I added C:\Program Files\Git\bin as well long with both of these to my PATH:
C:\Users\derek\AppData\Local\Yarn\bin
C:\Users\derek\AppData\Roaming\npm

Then as a rule I write .husky scripts using yarn ... or npm run ...... that seems to work well for me.

[Secreto31126]

Leaving my two cents here, I solved the issue by adding .cmd to the npx call in .husky/pre-commit:

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx.cmd lint-staged

Wild guess: I noticed I have both a "npx" and "npx.cmd" files in C:/Program Files/nodejs, and they are ordered alphabetically. IIRC, Windows pathing matchs the first file, which turns out to be the one without extension (probably a Linux binary from WSL). Again, wild guess, but maybe WSL is messing around in the issue.

[monstereat]

thank you boss

[celstark]

Leaving my two cents here, I solved the issue by adding .cmd to the npx call in .husky/pre-commit:

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx.cmd lint-staged

OMG thank you!

Here's my variant:

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

if [[ "$OS" == "Windows_NT" ]]; then
  npx.cmd lint-staged
else
  npx lint-staged
fi  

[PittsGitHub]

Leaving my two cents here, I solved the issue by adding .cmd to the npx call in .husky/pre-commit:

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx.cmd lint-staged

OMG thank you!

Here's my variant:

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

if [[ "$OS" == "Windows_NT" ]]; then
  npx.cmd lint-staged
else
  npx lint-staged
fi  

This fix so very nearly works for me but I'd been using regex as part of my command for prettier:
npx.cmd prettier --ignore-path .gitignore \"**/*.+(ts|json)\"

Which I can't seem to get to work inside husky for the life of me, so for now at least I've given up trying to make GitHub desktop work and just using the VSCode source control