Add style check and also fix style violations #3
Conversation
| // uncomment this line to temporarily disable spotless (i.e. when debugging) | ||
| // enforceCheck = false | ||
| java { | ||
| googleJavaFormat() |
There was a problem hiding this comment.
google-java-format produces bad formatting for type annotations.
Therefore, I don't think its use should be encouraged, in projects related to type annotations, until google/google-java-format#5 is fixed.
There was a problem hiding this comment.
Do you have a suggestion for a style checker that does not have bad formatting for type annotations? I'm not aware of one.
There was a problem hiding this comment.
https://github.com/plume-lib/run-google-java-format
It's not as convenient to use (ugly Gradle integration), but it formats correctly.
| "-Astubs=stubs/", | ||
| "-nowarn"); | ||
| } | ||
| public TemplateforaTest(List<File> testFiles) { |
There was a problem hiding this comment.
The Checker Framework uses the -a command-line argument to google-java-format, for 4-space indentation.
I dislike that, but we might want to keep this project consistent with the other Checker Framework repositories.
No description provided.