Skip to content

Don't output top annotations to .ajava files #6432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Don't output top annotations to .ajava files #6432

wants to merge 6 commits into from

Conversation

@mernst
Copy link
Member

@mernst mernst commented Jan 30, 2024 •
edited
Loading

Merge after #6431

@mernst mernst mentioned this pull request Jan 30, 2024
Open
@kelloggm
Copy link
Contributor

kelloggm commented Jan 30, 2024

While this change looks sensible, I can't see a difference between the output of this PR and master on either ./gradlew ainferResourceLeakAjavaTest or ./gradlew ainferIndexAjavaTest, both of which seem to already not include any top annotations on master. Can you point to a test case for which you expect this PR to change the output (even if that test case's .ajava files need to be inspected by-hand to see the difference)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kelloggm kelloggm

@smillst smillst

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mernst @kelloggm @smillst