Using local TS node module #6
Conversation
|
Awsome! It's pretty sad that this repository is kinda abandoned. Solution you've prepared is great |
|
@bdrazhzhov Could you help maintaining this repository? I'm willing to add you as a contributor. |
|
@tkawachi He has github account only for this fork, so i'm not sure if he's active. Could you accept this pull reqest? It would solve a lot of problems in https://github.com/typescript-ruby/typescript-rails repo |
| @typescript_path ||= ::Pathname.new(File.dirname(__FILE__)).join('typescript-src/support/typescript') | ||
| unless @typescript_path | ||
| begin | ||
| @typescript_path = ::Pathname.new(`npm root -g`.strip! + '/typescript') |
There was a problem hiding this comment.
This doesn't throw an exception even if the directory doesn't exist.
|
@tkawachi I'm new in RoR and I would like to help with maintaining this repository. |
|
Thank you @bdrazhzhov. I've invited you to this organisation. I hope you commit/merge pull requests. Currently none of organisation owners are active. BTW, I think it's not good to always detect npm installed tsc. It's better to be able to configure by library users. |
|
Oh... Thank you! Will implement it. |
Added ability to use external Typescript compiler
|
@tkawachi, could you provide me permission to push the gem to rubygems.org? What do you need to know from me for permission providing? |
|
@bdrazhzhov According to the FAQ, your email address which is registered to rubygems.org is needed. |
|
I used [email protected] for rubygems.org. |
|
I've added you to typescript-src and typescript-node as an owner. |
|
@bdrazhzhov Added you to owners of typescript-rails. Thanks to maintain it. |
I've added ability to use TS node module (if it's available) with fallback to internal module.
Now 1.4.x is stable branch and it does not include typescript.js file and I decided to use tsc.js as source file.