fix(typescript-estree): specific error for parserOptions.project not including a file #9584
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| } | ||
|
|
||
| astAndProgram.program.getTypeChecker(); // ensure parent pointers are set in source files | ||
| const relativeFilePath = path.relative( | ||
| parseSettings.tsconfigRootDir, |
There was a problem hiding this comment.
This used to be tsconfigRootDir || process.cwd(), but I'm pretty sure that's unnecessary. createParseSettings already defaults tsconfigRootDir to process.cwd().
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c201b6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
JoshuaKGoldberg
force-pushed
the
project-programs-not-found-error
branch
from
0ac9fb4
to
b58de4b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v8 #9584 +/- ##
=======================================
Coverage 87.91% 87.92%
=======================================
Files 397 397
Lines 13556 13556
Branches 3936 3936
=======================================
+ Hits 11918 11919 +1
Misses 1325 1325
+ Partials 313 312 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -9,7 +9,7 @@ export function useClipboard(code: () => string): useClipboardResult { | |||
|
|
|||
| const copy = useCallback( | |||
| () => | |||
| void navigator.clipboard.writeText(code()).then(() => { | |||
| navigator.clipboard.writeText(code()).then(() => { | |||
There was a problem hiding this comment.
This is also in the v8 branch. GitHub just isn't updating...
JoshuaKGoldberg
added
the
1 approval
PR Checklist
Parsing error: "parserOptions.programs"#9096Overview
When
parseSettings.projectsis populated,useProvidedProgramsnows refer toparserOptions.projectandproject(s)instead ofparserOptions.programsandprogram(s).Also applies a mild refactor to reduce nesting in the function.
I think after this I'd like to holistically revamp the error messages around invalid
💖