Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not pass tsconfig canonical file name to typescript API to get program details for config file #9042

Merged
merged 2 commits into from
May 6, 2024

Conversation

sheetalkamat
Copy link
Contributor

@sheetalkamat sheetalkamat commented May 3, 2024

PR Checklist

Overview

Without this it generates root files with incorrect casing and results in errors with casing with forceConsistentCasingInFileNames which is true by default in newer typescript versions

This came up while i was working on PR microsoft/TypeScript#58398

cc @jakebailey i was able to turn the tsconfig cache into Map and find all places where it needed to be string and was passing canonical file path

…am details for config file

Without this it generates root files with incorrect casing and results in errors with casing with forceConsistentCasingInFileNames which is true by default in newer typescript versions
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sheetalkamat!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b685720
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66356a0d614e4d0008d34eae
😎 Deploy Preview https://deploy-preview-9042--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JamesHenry JamesHenry changed the title Dont pass tsconfig canonical file name to typescript API to get program details for config file fix: do not pass tsconfig canonical file name to typescript API to get program details for config file May 4, 2024
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @sheetalkamat! So even without the change on the TS side this should massively help the linked OOM issue right?

@sheetalkamat
Copy link
Contributor Author

That’s right .. this should fix OOM with force consistent file name errors without typescript fix .. not sure if there are more places in which canonical path is passed in to API though ..

@JamesHenry
Copy link
Member

I'm going to go ahead and merge this, thanks again @sheetalkamat

@JamesHenry JamesHenry merged commit d166fdd into typescript-eslint:main May 6, 2024
58 of 60 checks passed
@sheetalkamat sheetalkamat deleted the configFileCasing branch May 6, 2024 18:21
@JoshuaKGoldberg
Copy link
Member

Woohoo, thanks for this !!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants