-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): update recommended configs #3809
feat(eslint-plugin): update recommended configs #3809
Conversation
Thanks for the PR, @MichaelDeBoey! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
bf7e525
to
082c568
Compare
packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts
Outdated
Show resolved
Hide resolved
b062183
to
80bd4c8
Compare
c6f4f20
to
cf309d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this doesn't fully resolve #3646 because there is a few default rule option change that we need to make to ban-types
- remove the object
type.
So if you want to do that here, that's great - or else we can do a separate PR.
Otherwise - need to remove that one thing which I messed up, and fix the CI - then this is good to go.
BREAKING CHANGE: recommended configs are changed
cf309d9
to
60e1ca5
Compare
@bradzacher I'll do that in a follow-up PR: #3818 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
BREAKING CHANGE: recommended configs are changed
Part of #3738
Part of #3746