Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used typescript-eslint's no-shadow in conversion #860

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Used typescript-eslint's no-shadow in conversion #860

merged 1 commit into from
Dec 12, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

@typescript-eslint/no-shadow is the right rule to convert to, as stated in the issue. It was added after our converter was originally written in typescript-eslint/typescript-eslint#2039.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Dec 12, 2020
KingDarBoja
KingDarBoja approved these changes Dec 12, 2020
View reviewed changes
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGTM

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2531cf6 into main Dec 12, 2020
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Dec 12, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the typescript-eslint-no-shadow branch December 12, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

const enums results in false positive with the rule "no-shadow"
2 participants
@JoshuaKGoldberg @KingDarBoja