Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rxjs-no-sharereplay #803

Merged
merged 2 commits into from
Nov 8, 2020
Merged

rxjs-no-sharereplay #803

merged 2 commits into from
Nov 8, 2020

Conversation

kbrilla
Copy link
Contributor

@kbrilla kbrilla commented Nov 7, 2020

PR Checklist

Overview

rxjs-no-sharereplay => rxjs/no-sharereplay

KingDarBoja
KingDarBoja approved these changes Nov 7, 2020
View reviewed changes
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these rule converters are pretty straightforward 🕺

@kbrilla
Copy link
Contributor Author

kbrilla commented Nov 7, 2020

Yeah, for now, I haven't found any changes in the behavior of rules for tslint and eslint. Maybe because they are written by the same guy.

@KingDarBoja KingDarBoja merged commit aa87503 into typescript-eslint:main Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rxjs-no-sharereplay
2 participants
@kbrilla @KingDarBoja