Defaulted --comment globs to --typescript settings #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
added
the
status: waiting for reviewer
|
LGTM 🚀 But I think it should support specifying a custom |
KingDarBoja
approved these changes
Sep 8, 2020
|
YES! Excellent idea, will file a followup issue! 👏 |
JoshuaKGoldberg
removed
the
status: waiting for reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
If
--commentsis provided astruefrom having no globs passed to it, we'll now default to a configuration provided by--typescriptif available. That necessitates passing in a found TypeScript configuration toconvertComments.Uses
minimatch(already a transitive runtime dependency) to emulate TypeScript'sexclude,files, andinclude.