Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add naming-convention merger #674

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Add naming-convention merger #674

merged 1 commit into from
Aug 10, 2020

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

Never had a good experience with mergers but guess this is the way to do it 😆

@KingDarBoja KingDarBoja added the status: waiting for reviewer Waiting for a maintainer to review label Aug 9, 2020
@KingDarBoja KingDarBoja added this to the Next milestone Aug 9, 2020
@KingDarBoja KingDarBoja self-assigned this Aug 9, 2020
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this!

I think there is the odd edge case possibility for both input rules to define different strategies for the same selector... but that's not something I think we should really put effort into accounting for.

@JoshuaKGoldberg JoshuaKGoldberg merged commit ee52ef7 into typescript-eslint:master Aug 10, 2020
@KingDarBoja KingDarBoja deleted the missing-naming-convention-merger branch August 11, 2020 13:17
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

@KingDarBoja KingDarBoja

Labels
status: waiting for reviewer Waiting for a maintainer to review
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

Missing Merger for @typescript-eslint/naming-convention
2 participants
@KingDarBoja @JoshuaKGoldberg