Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote wildcards for shell command #644

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

danvk
Copy link
Contributor

@danvk danvk commented Jul 23, 2020

PR Checklist

Overview

No existing issues, but I did run into one when running the command from the README:

$ npx tslint-to-eslint-config --prettier --comments **/*.ts[x]
npx: installed 56 in 4.615s

✨ 77 rules replaced with their ESLint equivalents. ✨

...

♻ 1 file of TSLint comment directives converted to ESLint. ♻

Whoops! My shell is eating up the glob. Really it should be quoted:

npx tslint-to-eslint-config --prettier --comments '**/*.tsx'
npx: installed 56 in 4.219s

✨ 77 rules replaced with their ESLint equivalents. ✨

...

♻ 144 files of TSLint comment directives converted to ESLint. ♻

@KingDarBoja KingDarBoja added the documentation Improvements or additions to docs label Jul 23, 2020
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 485fc03 into typescript-eslint:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants