Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-unused-variable converter #422

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Add no-unused-variable converter #422

merged 2 commits into from
Apr 29, 2020

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

Add no-unused-variable converter which includes a notice to read the article as this rule may change on the short-term.

@JoshuaKGoldberg not sure if it is the proper output but looks like both ESLint rules must be used on this converter.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing looks good -- just requesting changes on the extra rule output.

src/rules/converters/no-unused-variable.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Apr 27, 2020
@JoshuaKGoldberg JoshuaKGoldberg merged commit cdf8a69 into typescript-eslint:master Apr 29, 2020
@KingDarBoja KingDarBoja deleted the feature/no-unused-variable-converter branch April 29, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author The PR author should address requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing converter: no-unused-variable
2 participants