Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add one-line rule converter #413

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Add one-line rule converter #413

merged 2 commits into from
Apr 26, 2020

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

Add one-line TSLint converter to ESLint brace-style which will check all kind of tokens using the one true brace style option.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for reviewer Waiting for a maintainer to review label Apr 26, 2020
JoshuaKGoldberg
JoshuaKGoldberg requested changes Apr 26, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started on this - I think there's a bit more logic?

src/rules/converters/one-line.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: waiting for reviewer Waiting for a maintainer to review labels Apr 26, 2020
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit ecf6ee7 into typescript-eslint:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
status: waiting for author The PR author should address requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: one-line
2 participants
@KingDarBoja @JoshuaKGoldberg