Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used package install command for list of required ESLint-related packages #405

Merged
merged 2 commits into from
Apr 25, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 25, 2020

PR Checklist

Overview

Instead of displaying a line-by-line list of missing plugins, this creates a copy&paste-able command for the detected package manager (npm, pnpm, or Yarn) by lock file, or npm by default.

...

❓ 1 rule does not yet have an ESLint equivalent ❓
  See generated log file; defaulting to eslint-plugin-tslint for it.

⚡ 6 packages are required for running with ESLint. ⚡
  npm install @typescript-eslint/eslint-plugin @typescript-eslint/parser eslint eslint-plugin-import eslint-plugin-jsdoc eslint-plugin-prefer-arrow --save-dev

✅ All is well! ✅

Switches all converters to report plugins in the eslint-plugin- syntax, since they need to be installable by the package manager. I have a vague recollection of commenting on this / wanting it to be standardized recently but can't remember where. 🤷

@@ -18,6 +18,7 @@ module.exports = {
},
plugins: ["@typescript-eslint"],
rules: {
"@typescript-eslint/require-array-sort-compare": "off",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These came up during development. Annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend npm or yarn installation commands for packages
1 participant