No longer extend from removed/deprected Prettier ESLint configs #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version `8.0.0` of `eslint-config-prettier`, all configs have merged into `prettier` and supplying the extraneous configs results in error
JoshuaKGoldberg
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Beautiful, love to see the progress. Thanks @hyperupcall! ✨
|
This should be available in [email protected]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
--prettieralways results in a broken configuration #1396status: accepting prsOverview
Since
v8.0.0ofeslint-config-prettier, all configs have merged intoprettierand supplying the extraneous configs like"prettier/@typescript-eslint", etc. results in errorThis fix simply removes the no-longer-needed configs to extend from