Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [variable-name] Use id-denylist ESLint rule instread of id-blacklist that deprecated #1221

Merged
merged 2 commits into from
Sep 18, 2021

Conversation

wafuwafu13
Copy link
Contributor

PR Checklist

Overview

id-blacklist was deprecated in favor of id-denylist since ESLint 7.4.0.

I was able to confirm that the logic of the options is the same, so I just renamed it.

id-blacklist
https://github.com/eslint/eslint/blob/47be8003d700bc0606495ae42610eaba94e639c5/lib/rules/id-blacklist.js#L140-L153

id-denylist
https://github.com/eslint/eslint/blob/47be8003d700bc0606495ae42610eaba94e639c5/lib/rules/id-denylist.js#L121-L134

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖 love it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants