Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug fix] Fixing conversion rules #1191

Merged
merged 2 commits into from
Aug 26, 2021
Merged

[Bug fix] Fixing conversion rules #1191

merged 2 commits into from
Aug 26, 2021

Conversation

viditganpi
Copy link
Contributor

PR Checklist

Overview

The PR fixes the issue of incorrect converter for no-cookies rule as well as no-exec-script rule, from restricted-syntax to no-restricted-syntax

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2a5e9f7 into typescript-eslint:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect rule conversion for no-cookies tslint rule
2 participants
@viditganpi @JoshuaKGoldberg