Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricted missing package message checking to first 2 lines #1046

Merged
merged 1 commit into from
May 15, 2021
Merged

Restricted missing package message checking to first 2 lines #1046

merged 1 commit into from
May 15, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Limits the checking to just the summary and potential next line, to avoid seeing nested errors about missing config files.

KingDarBoja
KingDarBoja approved these changes May 10, 2021
View reviewed changes
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚦 All good!

@JoshuaKGoldberg JoshuaKGoldberg merged commit c247a81 into main May 15, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the confused-find-original-configs branch May 15, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails with cryptic error if unspecified default .eslintrc.js is missing
2 participants
@JoshuaKGoldberg @KingDarBoja