Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding newly added PoolOptions #16

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

franck-nadeau
Copy link
Contributor

The following PR added two new options to mysql's Pool creation.

I am simply adding them to the library in this PR.

The following [PR](sidorares/node-mysql2#1081) added two new options to mysql's Pool creation.

I am simply adding them to the library in this PR.
@unional unional merged commit 41e3814 into types:master Jan 14, 2020
@unional
Copy link
Contributor

unional commented Jan 14, 2020

thx!

@akleiber
Copy link

@unional how to get this released? :-)

@unional
Copy link
Contributor

unional commented Mar 18, 2020

typing is deprecated, so to use this library, you should include it as github dependency directly.
Here is an article on how to do it:
https://medium.com/@jonchurch/use-github-branch-as-dependency-in-package-json-5eb609c81f1a

There are some work lately on getting some bot to make these publish automatically, but I haven't hear much news about it in the last few weeks.

Another thing can be done is try to migrate this to DT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants