Relax private constraint for exception classes. #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#192 made some classes private, and hasn't been released. I tested it out in a few more codebases, and have found some new use cases for having public exception types.
Pattern matching
While users shouldn't construct exceptions explicitly, they may want to pattern match on them:
Control flow with
EitherUsers might also want to explicitly construct
ExpectationFailedfor control flow. For example, the following code can't be written using our public API:I don't think we should expose the
ExpectationFailedconstructor in the long term, but can do so in the short term and replace it with a helper function in future.