Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -language:strictEquality compiler flag #112

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

joan38
Copy link
Contributor

@joan38 joan38 commented Mar 11, 2024

No description provided.

@joan38
Copy link
Contributor Author

joan38 commented Apr 2, 2024

cc @satorg

Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@satorg
Copy link
Contributor

satorg commented Apr 3, 2024

Actually, it took me some time to check this PR.
Turns out that in Scala3 the -language option works in a bit weird way:

  • -language:help does not provide a list of available choices.
  • -lanugage:ANY_INCORRECT_OPTION does not fail with an error.

All the Scala2 versions I checked with work in a more expected way....

I created a topic about it in Scala Contributors hoping to get some clarification on that.

UPDATE: it was confirmed as a bug, see scala/scala3#20083

@joan38
Copy link
Contributor Author

joan38 commented Apr 19, 2024

I see.
So are we not adding this to the lib until we know it's failing if this option gets removed in the future?

@satorg
Copy link
Contributor

satorg commented Apr 19, 2024

No, why – I just allowed some time for dust to settle around this option (and the associated bug in the compiler). But then I blissfully forgot about this PR, sorry about it 😊

Thank you for the PR!

@satorg satorg merged commit 8e0fe0f into typelevel:main Apr 19, 2024
9 checks passed
@joan38
Copy link
Contributor Author

joan38 commented Apr 19, 2024

Thanks @satorg
Are we releasing a new version soon? I feel we had a lot of changes in since last year.

@satorg
Copy link
Contributor

satorg commented Apr 19, 2024

Are we releasing a new version soon? I feel we had a lot of changes in since last year.

@DavidGregory084 , @armanbilge , are we?
I personally don't mind, not sure if I can though.

To be honest, I've never ever cut off any release on GitHub myself 😨 . David, Arman, how do we do it, just in case?

@TonioGela
Copy link
Member

Are we releasing a new version soon? I feel we had a lot of changes in since last year.

@DavidGregory084 , @armanbilge , are we? I personally don't mind, not sure if I can though.

To be honest, I've never ever cut off any release on GitHub myself 😨 . David, Arman, how do we do it, just in case?

I can publish it, if we all agree that it's time to. Consider that in order to get in sbt-tpolecat we would also need to release that.

@joan38
Copy link
Contributor Author

joan38 commented Apr 20, 2024

I personally use this lib directly in Mill and stopped using mill-tpolcat:
https://github.com/joan38/kubernetes-client/blob/main/build.sc#L27

So I'm ok for sbt or mill-tpolcat to not pick up this version.

@joan38 joan38 deleted the strict-equality branch April 20, 2024 15:08
@armanbilge
Copy link
Member

To be honest, I've never ever cut off any release on GitHub myself 😨 . David, Arman, how do we do it, just in case?

https://typelevel.org/sbt-typelevel/faq.html#how-do-i-cut-a-release

@joan38
Copy link
Contributor Author

joan38 commented May 16, 2024

@TonioGela any news on the release? Thanks

@joan38
Copy link
Contributor Author

joan38 commented May 31, 2024

@satorg @armanbilge Any way we could cut a release?

@satorg
Copy link
Contributor

satorg commented May 31, 2024

@joan38, I think I can try to arrange it on the weekends (if there are no objections, of course).
Thank you for your contribution!

@TonioGela
Copy link
Member

@TonioGela any news on the release? Thanks

Sorry for the delay, I've completely skipped this notification.
0.1.5 was just released, enjoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants