SpanBuilder: replace startResource
with wrapResource
#86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are three options to start a span:
startResource
bothers me a bit.Rather than providing
startResource
, we can introducewrapResource
and utilize an abstract type to infer the output.With these changes, there are only two options to start the span.
The result type is inferred automatically:
The API change is the following:
Pros:
startUnmanaged
orwrapResource
on a builder that wraps a resourcestart
infers the result type automaticallyCons:
P.S. The implementation of
Runner
is dirty. If we agree on design changes, I will provide a more elegant one.