Scaladoc: Update max name length of a metric instrument #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
changed the title
armanbilge
reviewed
Sep 9, 2023
Comment on lines
31
to
34
| * @param unit | ||
| * the measurement unit. Must be 63 or fewer ASCII characters. | ||
| * the measurement unit. Must be 255 or fewer ASCII characters. | ||
| */ | ||
| def withUnit(unit: String): Self |
There was a problem hiding this comment.
Hmm, I'm confused. The spec change is in open-telemetry/opentelemetry-specification#3648 and it is about the instrument name, not the unit, which is documented below.
There was a problem hiding this comment.
Two pairs of eyes are better than one!
Good catch. I guess we can close the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from
1.30.0, the max length of a metric instrument can be 255 ASCII characters.https://github.com/open-telemetry/opentelemetry-java/releases/tag/v1.30.0