Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Oracle via Doobie #662

Closed
wants to merge 4 commits into from
Closed

Added support for Oracle via Doobie #662

wants to merge 4 commits into from

Conversation

milessabin
Copy link
Member

Work in progress ...

@milessabin milessabin self-assigned this Oct 5, 2024
@milessabin milessabin marked this pull request as draft October 5, 2024 21:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.89%. Comparing base (6bd6ba9) to head (9bd0b28).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
modules/sql-core/src/main/scala/SqlMapping.scala 77.77% 8 Missing ⚠️
...ie-oracle/src/main/scala/DoobieOracleMapping.scala 94.73% 1 Missing ⚠️
...es/sql-pg/shared/src/main/scala/SqlPgMapping.scala 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
+ Coverage   75.60%   75.89%   +0.29%     
==========================================
  Files          32       34       +2     
  Lines        5030     5091      +61     
  Branches     1094     1091       -3     
==========================================
+ Hits         3803     3864      +61     
  Misses       1227     1227              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpolecat
Copy link
Member

tpolecat commented Oct 5, 2024

Oracle? Wow, my condolences.

@milessabin milessabin requested a review from tpolecat October 6, 2024 09:12
@milessabin
Copy link
Member Author

@tpolecat the biggest job turned out to be rejigging the organisation of the various modules, and reworking the way docker is used in the tests/demo (the Oracle image takes way too long to startup and shutdown to run that cycle once for each suite).

I imagine you'll want to avert your gaze from the Oracle specifics, but I'd welcome your feedback on the reorg, the docker usage and also this change in the skunk module (currently a Session resource is use'd once per-fetch, which is probably harmless in the presence of a connection pool, but I think not ideal).

This will stay as WIP until the accompanying SQL Server module lands.

@milessabin
Copy link
Member Author

Superseded by #675.

@milessabin milessabin closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants