fixing "TIMESTAMP WITH TIMEZONE" typo #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well spotted, and the fix looks good. I'm not completely sure I understand why this is the right test to add to to exercise the fix though ... wouldn't it be better suited to |
milessabin
approved these changes
Dec 14, 2023
|
Hi, I was initially thinking about adding the test to the MovieSuite, but struggled to make it fail - it would require writing the query resulting in UNION (with date-time attribute skipped in one of the queries) if I get it right. |
|
That's good enough for me for now. Thanks again! We probably need to revisit the structure of some of these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing a typo in the doobie timezoned time mapping;
there was
TIMEZONE, it should beTIME ZONEextending Coalesce test to cover this