Fixed memory leak in concurrent.join #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd until the end of the outer stream
|
The old implementation was complicated and this fix makes it significantly worse. Not sure if we should merge this or go with @pchlupacek's new implementation of |
|
@mpilquist I am not quite sure that the amount of changes in this variant justifies the old code. I am not sure about the fact you indicating about performance benefit in my rewrite you indicating, but overall I think my rewritten version is easier to reason about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old implementation, the
doneQueuewas only processed whenopen == maxOpen. The new implementation drains thedoneQueueeagerly, ensuring timely finalization, while also draining it after reaching the end of the outer stream.Fixes #834. Alternate to #836.