Make null param error more informative (#809) #2143
+41
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatcwang
reviewed
Nov 21, 2024
| case None => unsafeSetNull(ps, n) | ||
| } | ||
|
|
||
| private def unsafeSetWhatShouldNotBeNull(ps: PreparedStatement, n: Int, a: A, message: Int => String): Unit = |
There was a problem hiding this comment.
I believe this will still allocate the anonymous function (unless JIT is able to elide the allocation?)
There was a problem hiding this comment.
That's actually a good point, but is it so if it's an axisting method passed as an argument? How is it compiled to bytecode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2141 but with more information.
The error message string is created only in
if (a == null)branch ( to solve issue spotted here #2141 (comment) )